Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use h5iostorage directly #166

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Use h5iostorage directly #166

merged 7 commits into from
Jan 18, 2024

Conversation

liamhuber
Copy link
Member

@liamhuber liamhuber commented Jan 16, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/use_h5iostorage_directly

@codacy-production Codacy Production
Copy link

codacy-production bot commented Jan 16, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for bd62c771 ✅ 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd62c77) Report Missing Report Missing Report Missing
Head commit (bba2ec5) 2694 2227 82.67%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#166) 10 5 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

liamhuber and others added 5 commits January 17, 2024 16:24
@liamhuber
Don't rely on return behaviour on DirectoryObject.delete
028ecbc
@liamhuber
Revert the return behaviour on DirectoryObject.delete
90dc5ab 
It was just weird. Just explicitly check for empty. Honestly, we can probably revert the `only_if_empty` kwarg too, but that can be its own PR.
@liamhuber
Remove comment
2c5fbe5
@liamhuber
No magic strings
2cb5167
@pyiron-runner
[dependabot skip] Update env file
bba2ec5
@liamhuber liamhuber marked this pull request as ready for review January 18, 2024 00:38
@liamhuber liamhuber merged commit 00a5709 into simple_storage Jan 18, 2024
13 checks passed
@liamhuber liamhuber deleted the use_h5iostorage_directly branch January 18, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamhuber @pyiron-runner